Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Tests: Adds unit test covering the Id-encoding end-to-end #3307

Conversation

FabianMeiswinkel
Copy link
Member

Pull Request Template

Description

Got reports that certain valid characters in id were not handled appropriately in node.js SDK (space at the end of id for example). When testing I realized inconsistency across SDKs and even Gateway vs. Direct - so I will go through and create a baseline with end-to-end tests in all SDKs and then see how we can fix this situation (and whether we think it is important to fix vs. just better and more clear document the various constraints)

Overview is here: https://microsofteur-my.sharepoint.com/:x:/g/personal/fabianm_microsoft_com/EdA2zPvwjfxCo05SKu4FQXMBpnt_8HpDgSIOxWZqpjkikQ?e=6hX4ud

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@FabianMeiswinkel FabianMeiswinkel changed the title Adds unit test covering the Id-encoding end-to-end [Internal] Tests: Adds unit test covering the Id-encoding end-to-end Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants