Diagnostics: Fixes Ordering of ClientConfiguration Initialization #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanvt
requested review from
khdang,
sboshra,
adityasa,
neildsh and
kirankumarkolli
as code owners
imanvt
requested review from
ealsur,
FabianMeiswinkel and
kirillg
as code owners
ealsur
reviewed
Aug 18, 2022
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ClientCreateAndInitializeTest.cs
Outdated
Show resolved
Hide resolved
ealsur
approved these changes
Aug 19, 2022
|
So, this is an issue, and it will be resolved in the new SDK version, right? |
|
Released on 3.30.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The cachedSerializedJson from the client configuration was getting updated before the connection mode was initialized, so the default connection mode was getting output instead of the one set in the client options
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3387