Patch: Adds public to PatchOperation<T> class for testing #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for casting return object of PatchOperation methods
Tests for casting return object of PatchOperation methods
…decodingahmed/azure-cosmos-dotnet-v3 into feature/public-patchoperation-t
…decodingahmed/azure-cosmos-dotnet-v3 into feature/public-patchoperation-t
…decodingahmed/azure-cosmos-dotnet-v3 into feature/public-patchoperation-t
decodingahmed
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
decodingahmed
changed the title
PatchOperation<T> publicPatchOperation<T> public
decodingahmed
changed the title
PatchOperation<T> publicPatchOperation<T> public
decodingahmed
changed the title
PatchOperation<T> publicpublic to PatchOperation<T> class
decodingahmed
changed the title
public to PatchOperation<T> class
decodingahmed
changed the title
PatchOperation<T> class
decodingahmed
changed the title
PatchOperation<T> class
|
/azp run |
1 similar comment
|
/azp run |
ealsur
approved these changes
Aug 24, 2022
ealsur
requested changes
Aug 24, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Patch/PatchOperationTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Patch/PatchOperation{T}Tests.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ealsur
changed the title
ealsur
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
PatchOperation<T>object is now made public. This will allow consumers to cast anyPatchOperationobjects to thePatchOperation<T>class in order to access theValueproperty.For the author's use-case this will allow tests to check that the service level code is passing correct values into the patch request.
In order to avoid introducing a breaking change, these changes do not change the return type of the
Add,Set,ReplaceandIncrementmethods of thePatchOperationclass.This PR addresses: #3374
Type of change
Closing issues
Closes #3374