PartitionKeyRangeCache: Fixes duplicate trace key generation #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yRangeCache Computation.
ealsur
reviewed
Aug 30, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/PartitionKeyRangeCacheTest.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Aug 30, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/PartitionKeyRangeCacheTest.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Aug 30, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/PartitionKeyRangeCacheTest.cs
Outdated
Show resolved
Hide resolved
kundadebdatta
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
ealsur
previously approved these changes
Aug 31, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/PartitionKeyRangeCacheTest.cs
Outdated
Show resolved
Hide resolved
ealsur
approved these changes
Aug 31, 2022
kundadebdatta
added a commit
that referenced
this pull request
Sep 1, 2022
* Code changes to fix duplicate trace key generation during PartitionKeyRangeCache Computation. * Code changes to address review comments. * Code changes to remove TestInitialize annotation.
kundadebdatta
added a commit
that referenced
this pull request
Sep 1, 2022
* Code changes to fix duplicate trace key generation during PartitionKeyRangeCache Computation. * Code changes to address review comments. * Code changes to remove TestInitialize annotation.
ealsur
pushed a commit
that referenced
this pull request
Sep 1, 2022
…#3438) * PartitionKeyRangeCache: Fixes duplicate trace key generation (#3430) * Code changes to fix duplicate trace key generation during PartitionKeyRangeCache Computation. * Code changes to address review comments. * Code changes to remove TestInitialize annotation. * 3.30.1: Adds new SDK versions and contract files (#3436) * Updated change log and bumped up the version. * Code changes to add detailed change log.
ealsur
pushed a commit
that referenced
this pull request
Sep 1, 2022
…neration (#3440) * PartitionKeyRangeCache: Fixes duplicate trace key generation (#3430) * Code changes to fix duplicate trace key generation during PartitionKeyRangeCache Computation. * Code changes to address review comments. * Code changes to remove TestInitialize annotation. * 3.30.1: Adds new SDK versions and contract files (#3436) * Updated change log and bumped up the version. * Code changes to add detailed change log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Code changes to fix duplicate trace key generation during the
GetFeedRangesAsync()API call. The same key could be re-generated, if the CPU computation is fast enough to invokeTryLookupAsyncwithin.5msto15mstimeframe, which may eventually lead to get the exact sameDateTime.UtcNow, which was nothing but the trace key. See this for more information.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3383