-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientRetryPolicy: Fixes behavior to Meta-data write operations in multimaster accounts #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
reviewed
Sep 21, 2022
ealsur
reviewed
Sep 21, 2022
ealsur
reviewed
Sep 21, 2022
ealsur
reviewed
Sep 21, 2022
ealsur
reviewed
Sep 21, 2022
ealsur
requested changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests to cover any changes to the files and behaviors and see the other comments, good starting point!
ealsur
reviewed
Sep 21, 2022
ealsur
reviewed
Sep 21, 2022
ealsur
reviewed
Sep 23, 2022
ealsur
reviewed
Sep 23, 2022
ealsur
reviewed
Sep 23, 2022
ealsur
reviewed
Sep 27, 2022
ealsur
reviewed
Sep 27, 2022
ealsur
reviewed
Sep 27, 2022
ealsur
reviewed
Sep 27, 2022
ealsur
reviewed
Sep 27, 2022
…y into retryContext
NaluTripician
requested review from
khdang,
adityasa,
neildsh,
kirankumarkolli and
FabianMeiswinkel
as code owners
September 30, 2022 16:16
ealsur
previously approved these changes
Sep 30, 2022
ealsur
approved these changes
Oct 3, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In the issue, for multimaster accounts where the
LimitToEndpoint
flag is set to true and the endpoint is specified to the non-hub region, all metadata write operations will fail because we are trying to perform a write on a non-bub region that does not have access to the master partition. The failure will be a 403.3 error and the current way theClientRetryPolicy
is set up, these metadata write operations will not retry as theenableEndpointDiscovery
flag is set to false whenLimitToEndpoint
is true. In theLocationCache
. By changing the behavior of the 'ClientRetryPolicy' to retry metadata write opeations andLocationCache
to check to see if it is a retried metadata write operation and then to reroute to the hub region, this problem can be mitigated.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3408