AI Integration: Fixes Container and Database name in attributes #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
sourabh1007
force-pushed
the
users/sourabhjain/aidbinfofix
branch
4 times, most recently
from
cd21518
to
731645d
Compare
ealsur
reviewed
Sep 26, 2022
Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedIteratorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedEstimatorIterator.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse{T}.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Tracing/OpenTelemetryListener.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/FeedIterators/FeedIteratorInlineCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 28, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse{T}.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 28, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse{T}.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 28, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 28, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/Filters/DiagnosticsFilterHelper.cs
Show resolved
Hide resolved
sourabh1007
commented
Sep 28, 2022
Microsoft.Azure.Cosmos/src/ChangeFeed/ChangeFeedPartitionKeyResultSetIteratorCore.cs
Show resolved
Hide resolved
sourabh1007
commented
Sep 28, 2022
sourabh1007
force-pushed
the
users/sourabhjain/aidbinfofix
branch
3 times, most recently
from
c8cde8e
to
d851a78
Compare
ealsur
reviewed
Sep 29, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 29, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse{T}.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 30, 2022
ealsur
reviewed
Sep 30, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse{T}.cs
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/aidbinfofix
branch
from
4c03a61
to
243985d
Compare
sourabh1007
force-pushed
the
users/sourabhjain/aidbinfofix
branch
from
243985d
to
6566cc6
Compare
ealsur
reviewed
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noticed that container name and database name information is not getting populated for some operations like bulk/query/changefeed etc.
As part of this PR making sure, we always have container and database name in the opentelemetry attributes.
Type of change