Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add Optimistic Direct Execution configuration override support on the Client #4122

Merged
merged 26 commits into from
Dec 13, 2023
Merged

Query: Add Optimistic Direct Execution configuration override support on the Client #4122

merged 26 commits into from
Dec 13, 2023

Conversation

akotalwar
Copy link
Contributor

@akotalwar akotalwar commented Oct 13, 2023 •
edited
Loading

Pull Request Template

Description

This PR accepts a new flag from the backend which tells the client whether or not to use the Ode code path.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@akotalwar
Added ability to accept the AllowOptimisticDirectExecution flag from …
085d7d5 
…the backend and use that flag to decide if the Ode pipeline should be used or not.
@akotalwar akotalwar added QUERY auto-merge Enables automation to merge PRs labels Oct 23, 2023
@neildsh
Copy link
Contributor

neildsh commented Oct 23, 2023

//------------------------------------------------------------

Please remove from the PR if there are no modifications

Refers to: Microsoft.Azure.Cosmos/src/Query/v3Query/QueryIterator.cs:1 in 2191de4. [](commit_id = 2191de4, deletion_comment = False)

adityasa
adityasa previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

neildsh
neildsh previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@neildsh neildsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@akotalwar akotalwar dismissed stale reviews from neildsh and adityasa via a953803 October 27, 2023 16:32
neildsh
neildsh previously approved these changes Oct 27, 2023
View reviewed changes
adityasa
adityasa previously approved these changes Oct 27, 2023
View reviewed changes
@akotalwar akotalwar dismissed stale reviews from adityasa and neildsh via f8cc146 December 7, 2023 15:19
neildsh
neildsh approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@neildsh neildsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

adityasa
adityasa approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 6258e24 into master Dec 13, 2023
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/akotalwar/ODEGatewayConfig branch December 13, 2023 02:00
@adityasa adityasa mentioned this pull request Jan 24, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neildsh neildsh neildsh approved these changes

@adityasa adityasa adityasa approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akotalwar @neildsh @ealsur @adityasa