Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GatewayClientStore: Fixes an issue with dealing with invalid JSON HTTP responses #4229

Conversation

philipthomas-MSFT
Copy link
Contributor

Description

Fixes an issue when Error string/stream from Gateway response cannot be deserialized.
For more information, see #4162

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #4162

@philipthomas-MSFT philipthomas-MSFT marked this pull request as draft January 4, 2024 14:07
@philipthomas-MSFT philipthomas-MSFT self-assigned this Jan 4, 2024
@philipthomas-MSFT philipthomas-MSFT marked this pull request as ready for review January 4, 2024 22:41
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! Thanks for doing this

Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs Outdated Show resolved Hide resolved
Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs Outdated Show resolved Hide resolved
Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs Outdated Show resolved Hide resolved
ealsur
ealsur previously approved these changes Jan 9, 2024
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small nits

Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs Outdated Show resolved Hide resolved
Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs Outdated Show resolved Hide resolved
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Jan 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 8af055c into master Jan 10, 2024
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the 4162-handle-invalid-json-http-response-from-gateway-for-error-scenarios branch January 10, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Handle invalid JSON HTTP response from Gateway for error scenarios
4 participants