-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GatewayClientStore: Fixes an issue with dealing with invalid JSON HTTP responses #4229
Merged
microsoft-github-policy-service
merged 16 commits into
master
from
4162-handle-invalid-json-http-response-from-gateway-for-error-scenarios
Jan 10, 2024
Merged
GatewayClientStore: Fixes an issue with dealing with invalid JSON HTTP responses #4229
microsoft-github-policy-service
merged 16 commits into
master
from
4162-handle-invalid-json-http-response-from-gateway-for-error-scenarios
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipthomas-MSFT
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
December 27, 2023 18:31
sourabh1007
reviewed
Jan 2, 2024
sourabh1007
reviewed
Jan 2, 2024
sourabh1007
reviewed
Jan 2, 2024
ealsur
reviewed
Jan 2, 2024
ealsur
reviewed
Jan 3, 2024
ealsur
reviewed
Jan 3, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/GatewayStoreClientTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jan 3, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/GatewayStoreClientTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jan 3, 2024
ealsur
reviewed
Jan 3, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/GatewayStoreClientTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress! Thanks for doing this
…m-gateway-for-error-scenarios
…. I will maybe come back to it later.
ealsur
previously approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few small nits
ealsur
approved these changes
Jan 9, 2024
sourabh1007
approved these changes
Jan 10, 2024
microsoft-github-policy-service
bot
deleted the
4162-handle-invalid-json-http-response-from-gateway-for-error-scenarios
branch
January 10, 2024 09:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue when
Error
string/stream from Gateway response cannot be deserialized.For more information, see #4162
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4162