ChangeFeedProcessor: Fixes when ChangeFeedMode is switched should throw an exception. #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessor-switching-changefeedmode-should-throw-an-exception
philipthomas-MSFT
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
philipthomas-MSFT
changed the title
ealsur
reviewed
Mar 1, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedEstimatorRunner.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 1, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorBuilder.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 1, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 1, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
requested changes
Mar 1, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
…rocessor-switching-changefeedmode-should-throw-an-exception
…rocessor-switching-changefeedmode-should-throw-an-exception
ealsur
reviewed
Mar 20, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 20, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 20, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 20, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/LeaseManagement/DocumentServiceLease.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 20, 2024
...re.Cosmos/src/ChangeFeedProcessor/LeaseManagement/DocumentServiceLeaseStoreManagerBuilder.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Mar 20, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
…rocessor-switching-changefeedmode-should-throw-an-exception
ealsur
previously approved these changes
Mar 20, 2024
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedEstimatorRunner.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedProcessorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/LeaseManagement/DocumentServiceLease.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/LeaseManagement/DocumentServiceLeaseCoreEpk.cs
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Mar 21, 2024
ealsur
approved these changes
Mar 21, 2024
…rocessor-switching-changefeedmode-should-throw-an-exception
microsoft-github-policy-service
bot
deleted the
users/philipthomas-MSFT/4308-change-feed-processor-switching-changefeedmode-should-throw-an-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
See #4308 for problem statement, repro, scenarios, expected behavior, etc.
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4308