Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Adds support for non streaming ORDER BY #4362

Merged
merged 36 commits into from
Apr 1, 2024
Merged

Query: Adds support for non streaming ORDER BY #4362

merged 36 commits into from
Apr 1, 2024

Commits on Mar 28, 2024

  1. Initial prep for adding a non streaming order by query pipline stage

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2d90f0f View commit details
    Browse the repository at this point in the history

  2. Change TracingAsyncEnumerator to be an adapter class between ITracing… 

    …AsyncEnumerator and IAsyncEnumerator
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    92a0625 View commit details
    Browse the repository at this point in the history

  3. Move TracingAsyncEnumerator to product code

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0eff840 View commit details
    Browse the repository at this point in the history

  4. Change ITracingAsyncEnumerator.MoveNext to take a CancellationToken, … 

    …thereby removing the awkward method SetCancellationToken from IQueryPipelineStage
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3ae0b62 View commit details
    Browse the repository at this point in the history

  5. draft implementation of non streaming order by pipeline stage

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0ff0687 View commit details
    Browse the repository at this point in the history

  6. Fix bug that drops first record on an initialized page

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b252123 View commit details
    Browse the repository at this point in the history

  7. Add a test class for non streaming order by unit tests

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    163f31f View commit details
    Browse the repository at this point in the history

  8. remove unnecessary usings

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    83e1726 View commit details
    Browse the repository at this point in the history

  9. Add an emulator test for non streaming order by. Also lay groundwork … 

    …for an alternative implementation for non streaming order by
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bf2e7dd View commit details
    Browse the repository at this point in the history

  10. Remove the ResponseLengthInBytes property from QueryPage. This was be… 

    …ing calculated incorrectly, and seems to be unused to boot.
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    275b063 View commit details
    Browse the repository at this point in the history

  11. Add an ItemCount property to the Page class

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    94e3125 View commit details
    Browse the repository at this point in the history

  12. Add a multi level heap implementation for non streaming order by

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9eb7809 View commit details
    Browse the repository at this point in the history

  13. Add infrastructure for writing parity tests

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ce69f9d View commit details
    Browse the repository at this point in the history

  14. Fix a bug that caused the page enumerator to be dropped when we reach… 

    … flat heap sizze limit
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    702c7ad View commit details
    Browse the repository at this point in the history

  15. When cloning OrderByQueryPartitionRangePageAsyncEnumerator as a fully… 

    … buffered enumerator, make sure that we set the page size to maximum for the backend requests
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cb874da View commit details
    Browse the repository at this point in the history

  16. Simplify the non streaming pipeline stage, and add performance test

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    97d93d9 View commit details
    Browse the repository at this point in the history

  17. Revert the changes for Headers.ItemCount Keep it as a string

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    075cb46 View commit details
    Browse the repository at this point in the history

  18. Avoid an allocation each time the OrderByItems property of OrderByQue… 

    …ryResult is touched
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1d02ee8 View commit details
    Browse the repository at this point in the history

  19. Fix up the OrderByPipelineSatgeBenchmark to use fully materialized Co… 

    …smosElements in the oages returned from MockContainer
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5f464d0 View commit details
    Browse the repository at this point in the history

  20. Add a few more unit tests for non streaming order by

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8089fdf View commit details
    Browse the repository at this point in the history

  21. Add emulator tests for non streaming order by

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6e5a807 View commit details
    Browse the repository at this point in the history

  22. Add a few more integration test cases

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    82bde9b View commit details
    Browse the repository at this point in the history

  23. Fix up broken unit test

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    be3fb81 View commit details
    Browse the repository at this point in the history

  24. Add more test coverage for the non streaming order by

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c54e89b View commit details
    Browse the repository at this point in the history

  25. If there is no continuationtoken, assume that the response is streaming

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8babdb7 View commit details
    Browse the repository at this point in the history

  26. Add stronger validation to the non streaming order by unit tests

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    784295a View commit details
    Browse the repository at this point in the history

  27. Fix up broken unit tests to account for ItemCount

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    98218bb View commit details
    Browse the repository at this point in the history

  28. fix up plumbing for index utilization, and incorporate code review fe… 

    …edback
    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6b66ad2 View commit details
    Browse the repository at this point in the history

  29. Minor clean up

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6abe501 View commit details
    Browse the repository at this point in the history

  30. revert bug introduced in pursuit of more elegant code :)

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    cf6f04b View commit details
    Browse the repository at this point in the history

  31. fix up broken unit test

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3065ed1 View commit details
    Browse the repository at this point in the history

  32. Fix up broken perf test

    @neildsh
    neildsh committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b966a8a View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Fix up broken IndexMetricsParserBaselineTest

    @neildsh
    neildsh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    3661c36 View commit details
    Browse the repository at this point in the history

  2. Minor bug fixes for OrderByCrossPartitionEnumerator

    @neildsh
    neildsh committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    74f3eff View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into users/ndeshpan/nonStreamingOrderBy

    @neildsh
    neildsh authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    05befa6 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Merge branch 'master' into users/ndeshpan/nonStreamingOrderBy

    @neildsh
    neildsh authored Mar 30, 2024
    Configuration menu
    Copy the full SHA
    2942dd1 View commit details
    Browse the repository at this point in the history