FaultInjection: Adds SendDelay ServerErrorType #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
NaluTripician
changed the title
kirankumarkolli
previously approved these changes
Apr 23, 2024
ealsur
reviewed
Apr 24, 2024
...soft.Azure.Cosmos.Samples/Tools/FaultInjection/src/FaultInjectionServerErrorResultBuilder.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Apr 24, 2024
Microsoft.Azure.Cosmos.Samples/Tools/FaultInjection/tests/FaultInjectionDirectModeTests.cs
Outdated
Show resolved
Hide resolved
ealsur
approved these changes
Apr 25, 2024
kirankumarkolli
approved these changes
Apr 28, 2024
microsoft-github-policy-service
bot
deleted the
users/nalutripician/FaultInjectionBeforeAfterSend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds the
SendDelayServerErrorType. This error will add a delay before the request is sent to the backend. This is similar to the existingResponseDelayServerErrorType, who's behavior is also fixed in this PR.SendDelaywill add a delay to the request before sending.ResponseDelayfunctions the same however the delay is after sending the request but before sending the response.When the delay is set to above the timeout time and users are trying to mimic timeout scenarios, these two rules will allow users to decide whether they want the request to reach the backend or not.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber