Query: Adds an environment config to suppress sending NonStreamingOrderBy in the list of query features sent to the gateway #4492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to retrieve a query plan for non streaming order by queries, the sdk must send NonStreamingOrderBy in the list of supported query features to the gateway. However, older gateways will not recognize this new value, causing the query plan request to fail with a 400. To mitigate this edge case, we add a check for an environment variable
AZURE_COSMOS_NON_STREAMING_ORDER_BY_FLAG_DISABLED
, which when set toTrue
will suppress sending NonStreamingOrderBy in the list of supported query features.A note about the naming
It is named as
DISABLED
by design for two reasons:false
be the default for boolean flags. (Since C# will auto initialize to false for members.) If we name the flag asENABLED
, the default value would have to betrue
Type of change