Change Feed / Processor AVAD: Fixes timeToLiveExpired missing from metadata #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipthomas-MSFT
requested review from
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs
Outdated
Show resolved
Hide resolved
…liveexpired-deserialization-issue
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
ealsur
reviewed
Jun 4, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Please update the title in a way that makes sense for a customer when reading it in the changelog. Maybe Change Feed / Processor AVAD: Fixes timeToLiveExpired missing from metadata or something that when an external user without much context reads it, can understand what it fixed.
ealsur
reviewed
Jun 10, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 10, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
…liveexpired-deserialization-issue
ealsur
previously approved these changes
Jun 12, 2024
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Show resolved
Hide resolved
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Show resolved
Hide resolved
...smos.EmulatorTests/ChangeFeed/GetChangeFeedProcessorBuilderWithAllVersionsAndDeletesTests.cs
Outdated
Show resolved
Hide resolved
…. later PRs to test STJ de/serialization.
…liveexpired-deserialization-issue
…liveexpired-deserialization-issue
ealsur
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos.Samples/Usage/ReEncryption/ReEncryption.csproj
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Jun 17, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json
Show resolved
Hide resolved
…liveexpired-deserialization-issue
ealsur
approved these changes
Jun 17, 2024
kirankumarkolli
approved these changes
Jun 17, 2024
…liveexpired-deserialization-issue
…liveexpired-deserialization-issue
kirankumarkolli
deleted the
4510-change-feed-processor-avad-ttl-istimeliveexpired-deserialization-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Bug recognize when onboarding a customer that needed to set TTL on the item. timeToLiveExpired was not being deserialized and always returning default Boolean value of false. The TTL deletes where recognized in the feed, just wrong value for timeToLiveExpired.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber