[Internal] JsonObjectState: Refactors to allow dynamically increasing JsonMaxNestingDepth #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mum nesting depth. This will allow serialization/deserialization of Json with deeply nested objects or arrays. This is needed because distribution plans may contain expressions that are deeply nested beyond the current limit.
sc978345
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sc978345
changed the title
neildsh
reviewed
Jun 13, 2024
| Debug.Assert(this.jsonMaxNestingDepth < (1 << 15), "JsonMaxNestingDepth must be less than 2^15"); | ||
|
|
||
| byte[] newNestingStackBitmap = new byte[newJsonMaxNestingDepth / 8]; | ||
| Array.Copy(this.nestingStackBitmap, newNestingStackBitmap, Math.Min(this.nestingStackBitmap.Length, newNestingStackBitmap.Length)); |
There was a problem hiding this comment.
Please consider using Array.Resize
neildsh
reviewed
Jun 13, 2024
| @@ -168,5 +168,35 @@ public void TestUnknownStruct() | |||
| DateTime value = DateTime.MinValue; | |||
| ReadOnlyMemory<byte> result = JsonSerializer.Serialize(value); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void TestMaxNestingDepethResize() | |||
|
@sc978345 can you please take a look at the comments and address them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies Json object state to support dynamically increasing the maximum nesting depth. This will allow serialization/deserialization of Json with deeply nested objects or arrays. This is needed because distribution plans may contain expressions that are deeply nested beyond the current limit.
Previously, there was a hardcoded limit of 256 for JsonMaxNestingDepth. With this change, if the limit is reached, JsonObjectState will dynamically increase the value until the supported limit of 2^15 (32k) is reached
Type of change