-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CF/P AVAD: Fixes Deserialization of ChangeFeedItem and ChangeFeedMetadata to support System.Text.Json and Newtonsoft.Json #4618
Merged
microsoft-github-policy-service
merged 23 commits into
master
from
4616-cfp-avad-issues-with-serializationdeserialization-with-cosmossystemtextjsonserializer-and-custom-serializers
Aug 21, 2024
Merged
CF/P AVAD: Fixes Deserialization of ChangeFeedItem and ChangeFeedMetadata to support System.Text.Json and Newtonsoft.Json #4618
microsoft-github-policy-service
merged 23 commits into
master
from
4616-cfp-avad-issues-with-serializationdeserialization-with-cosmossystemtextjsonserializer-and-custom-serializers
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipthomas-MSFT
requested review from
a team,
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
August 1, 2024 14:33
…erialization-with-cosmossystemtextjsonserializer-and-custom-serializers
philipthomas-MSFT
changed the title
ChangeFeed/Processor: Fixes Deserialization of ChangeFeedItem and ChangeFeedMetadata to support System.Text.Json and Newtonsoft.Json
ChangeFeed/Processor AVAD: Fixes Deserialization of ChangeFeedItem and ChangeFeedMetadata to support System.Text.Json and Newtonsoft.Json
Aug 1, 2024
philipthomas-MSFT
changed the title
ChangeFeed/Processor AVAD: Fixes Deserialization of ChangeFeedItem and ChangeFeedMetadata to support System.Text.Json and Newtonsoft.Json
CF/P AVAD: Fixes Deserialization of ChangeFeedItem and ChangeFeedMetadata to support System.Text.Json and Newtonsoft.Json
Aug 1, 2024
ealsur
reviewed
Aug 2, 2024
ealsur
reviewed
Aug 2, 2024
....Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Aug 2, 2024
...oft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderWithCustomSerializerTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Aug 2, 2024
...oft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderWithCustomSerializerTests.cs
Outdated
Show resolved
Hide resolved
…s-with-serializationdeserialization-with-cosmossystemtextjsonserializer-and-custom-serializers
Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Aug 7, 2024
Microsoft.Azure.Cosmos/src/Resource/FullFidelity/Converters/ChangeFeedMetadataConverter.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Aug 7, 2024
kirankumarkolli
previously approved these changes
Aug 8, 2024
…erialization-with-cosmossystemtextjsonserializer-and-custom-serializers
....Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderTests.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderWithCustomSerializerTests.cs
Outdated
Show resolved
Hide resolved
…erialization-with-cosmossystemtextjsonserializer-and-custom-serializers
…s-with-serializationdeserialization-with-cosmossystemtextjsonserializer-and-custom-serializers
…with-cosmossystemtextjsonserializer-and-custom-serializers' of https://github.com/Azure/azure-cosmos-dotnet-v3 into 4616-cfp-avad-issues-with-serializationdeserialization-with-cosmossystemtextjsonserializer-and-custom-serializers
philipthomas-MSFT
dismissed stale reviews from kirankumarkolli and ealsur
via
August 16, 2024 15:14
d30e7af
...oft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderWithCustomSerializerTests.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Aug 17, 2024
...FP/AllVersionsAndDeletes/BuilderWithCustomSerializerPropertyNameCaseInsensitiveFalseTests.cs
Outdated
Show resolved
Hide resolved
...oft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderWithCustomSerializerTests.cs
Show resolved
Hide resolved
...oft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderWithCustomSerializerTests.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Aug 20, 2024
NaluTripician
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FabianMeiswinkel
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
microsoft-github-policy-service
bot
deleted the
4616-cfp-avad-issues-with-serializationdeserialization-with-cosmossystemtextjsonserializer-and-custom-serializers
branch
August 21, 2024 21:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Details in #4616
Usage
Deserialize
Payload
STJ
Serialize
STJ
With CosmosClientBuilder
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4616