Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFP AVAD: Adds new FeedRange to ChangeFeedProcessorContext #4621

Conversation

philipthomas-MSFT
Copy link
Contributor

Pull Request Template

Details on #4620

Description

Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #4620

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@philipthomas-MSFT philipthomas-MSFT changed the title CFP AVAD: Add new FeedRange to ChangeFeedProcessorContext CFP AVAD: Adds new FeedRange to ChangeFeedProcessorContext Aug 1, 2024
@philipthomas-MSFT
Copy link
Contributor Author

Blocking myself. Some other tests are failing and I need to run UpdateContracts.ps1

@philipthomas-MSFT philipthomas-MSFT requested a review from a team as a code owner August 1, 2024 18:59
@philipthomas-MSFT
Copy link
Contributor Author

Blocking myself. Some other tests are failing and I need to run UpdateContracts.ps1

Fixed

Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small polishing comments

…ProcessorOptions.cs

Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
philipthomas-MSFT and others added 2 commits August 6, 2024 03:44
ealsur
ealsur previously approved these changes Aug 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit ee33928 into master Aug 14, 2024
20 of 21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the 4620-cfp-avad-add-public-access-to-feedrange-from-changefeedprocessorcontext branch August 14, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CFP AVAD: Add public access to FeedRange from ChangeFeedProcessorContext
4 participants