[INTERNAL] Build: Fixes warnings in encryption project

[kirankumarkolli]

[INTERNAL] Build: Fix warnings in encryption project

[github-actions]

All good!

[JanHyka]

nit: seeing 'mdesrc' it looks like quite old copy of mde library... it might be worth considering just refencing at least 1.2.0 and getting rid of this copy, now that we have release versions.

[kirankumarkolli]

nit: seeing 'mdesrc' it looks like quite old copy of mde library... it might be worth considering just refencing at least 1.2.0 and getting rid of this copy, now that we have release versions.

Part of our PR its upgraded to 2.0.0-pre007 right?

[JanHyka]

nit: seeing 'mdesrc' it looks like quite old copy of mde library... it might be worth considering just refencing at least 1.2.0 and getting rid of this copy, now that we have release versions.

Part of our PR its upgraded to 2.0.0-pre007 right?

With 1.2.0 stable release you should have out of box improvements both on encryption algorithm as well as sql serializers, with no code changes on Cosmos.Encryption itself. However while switching from this mdesrc copy to real mde, I'd suggest benchmark before/after.

2.0.0 is on -pre until we can deploy it together with new Cosmos.Encryption.Custom -preview and validate everything works as intended. Even though we went hardcore with MDE2.0 testing (100% line/branch/mutation coverage) having partner service validation is still worth it. Also except few small cases 2.0.0 brings improvements purely via non-allocation api, there are almost no direct compute improvements, so upgrading to that compared to 1.2.0 without additional code changes in Cosmos.Encryption won't bring you much extra.

[philipthomas-MSFT]

LGTM