-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Adds hybrid search query pipeline stage #4794
Merged
microsoft-github-policy-service
merged 15 commits into
master
from
users/ndeshpan/hybridSearch
Oct 18, 2024
Merged
Query: Adds hybrid search query pipeline stage #4794
microsoft-github-policy-service
merged 15 commits into
master
from
users/ndeshpan/hybridSearch
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
neildsh
changed the title
Query: Add hybrid search query pipeline stage
Query: Adds hybrid search query pipeline stage
Oct 10, 2024
neildsh
requested review from
khdang,
sboshra,
adityasa,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
October 15, 2024 01:57
first draft of RRF implementation add code for paginating results and respect skip/take
…un of Hybrid Search!
fix build errors Add more integration tests with better validation Add more integration tests with better validation deleted gratuitous rewrite of sql query spec fix up typo that causes build break Fix up build break in OrderByPipelineStageBenchmark
neildsh
force-pushed
the
users/ndeshpan/hybridSearch
branch
from
October 15, 2024 19:05
8272288
to
94b14ba
Compare
sboshra
reviewed
Oct 16, 2024
...osoft.Azure.Cosmos/src/Query/Core/Pipeline/CrossPartition/HybridSearch/FullTextStatistics.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Oct 16, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Oct 16, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Oct 16, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Oct 16, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Oct 17, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Oct 17, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sboshra
previously approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neildsh
commented
Oct 17, 2024
...ry/Core/Pipeline/CrossPartition/HybridSearch/HybridSearchCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
Rename a couple of Hybrid Search methods to conform to code review feedback Update comment to be more helpful Tiny bit of clean up
sboshra
approved these changes
Oct 18, 2024
sc978345
approved these changes
Oct 18, 2024
microsoft-github-policy-service
bot
deleted the
users/ndeshpan/hybridSearch
branch
October 18, 2024 03:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds hybrid search query pipeline stage. This requires the new Direct package and gateway to be available in order to light up.
Given an input SQL such as:
The new query plan (encoded below as XML instead of JSON to help readability) is as follows:
We have a custom implementation for the global statistics inside the
HybridSearchCrossPartitionQueryPipelineStage
because it uses nested aggregates. Each of the component queries in the hybrid search query plan is cross partition, and we run them using the existing cross partition query pipelines.Note the use of placeholders such as
{documentdb-formattablehybridsearchquery-totaldocumentcount}
in the query plan. These need to be replaced by the global statistics.Type of change