-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Telemetry: Adds open telemetry based versioning #4854
Open Telemetry: Adds open telemetry based versioning #4854
Conversation
987f979
to
62fc4fb
Compare
27de48e
to
b048737
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/TracesStabilityFactory.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryStablityModes.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall but left two comments.
….com/Azure/azure-cosmos-dotnet-v3 into users/sourabhjain/versionininginotel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending perf validation
I will cover it is next PR |
Description
Introducing versioning for open telemetry attributes, to make we are always backward compatible.
Environment Variable
OTEL_SEMCONV_STABILITY_OPT_IN
value supported :database
=> Otel supported attributes. (right now, same as default, in future can be used to put any attribute change)database/dup
=> Otel and appinsights attributes ( for those, who are moving from appinsightclassic to otel)default
=> Otel Attributes (Breaking change, needs to be documented)appinsightssdk
=> backward compatibility to appinsights.Other minor changes,
db.cosmosdb.item_count
=>db.cosmosdb.row_count
Code changes Overview
TracesStabilityFactory.cs
: Responsible to take care of version based attributes.Type of change
Please delete options that are not relevant.