Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Telemetry: Adds open telemetry based versioning #4854

Merged

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Oct 25, 2024

Description

Introducing versioning for open telemetry attributes, to make we are always backward compatible.

Environment Variable OTEL_SEMCONV_STABILITY_OPT_IN value supported :
database => Otel supported attributes. (right now, same as default, in future can be used to put any attribute change)
database/dup => Otel and appinsights attributes ( for those, who are moving from appinsightclassic to otel)
default => Otel Attributes (Breaking change, needs to be documented)
appinsightssdk => backward compatibility to appinsights.

Other minor changes,

  1. Fix connection mode casing
{
              ConnectionMode.Direct => "direct",
              ConnectionMode.Gateway => "gateway",
              _ => throw new NotImplementedException()
          };
  1. rename db.cosmosdb.item_count => db.cosmosdb.row_count

Code changes Overview

  1. Introduced, TracesStabilityFactory.cs : Responsible to take care of version based attributes.
  2. Updated Baseline Tests to have old and new both attributes in contract file.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/versionininginotel branch from 987f979 to 62fc4fb Compare October 25, 2024 16:43
@sourabh1007 sourabh1007 marked this pull request as draft October 25, 2024 17:22
@sourabh1007 sourabh1007 marked this pull request as ready for review October 29, 2024 03:12
@sourabh1007 sourabh1007 self-assigned this Oct 29, 2024
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/versionininginotel branch from 27de48e to b048737 Compare October 31, 2024 02:43
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall but left two comments.

@sourabh1007 sourabh1007 mentioned this pull request Nov 13, 2024
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Nov 14, 2024
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending perf validation

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 925cebe into master Nov 14, 2024
23 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/versionininginotel branch November 14, 2024 16:01
@sourabh1007
Copy link
Contributor Author

Pending perf validation

I will cover it is next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs Telemetry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants