Open Telemetry : Adds implementation for network level Metrics #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more changes wip rewrite meters refactor code dimension names test fix contract update import fixes wip added other metrics code refactor add docuemnattion Delete Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Microsoft - Backup.Azure.Cosmos.EmulatorTests.csproj upodated contract
…ripts (#4813) [INTERNAL] CI: Fixes emulator set-up to leverage central SDK teams scripts Observations - Lessmsi: extraction taking longer (1M) then msiexec based model - Starting emulator from ProgramFolder path is faster - Unnecessary exponential retry logic (current one)
# Pull Request Template
## Description
This PR adds optional attributes in the `VectorIndexDefinition` class to
support partitioned DiskANN. A typical index definition would be
something like the below:
```
{
"indexingPolicy": {
"automatic": true,
"indexingMode": "Consistent",
"includedPaths": [
{
"path": "/*",
"indexes": []
}
],
"excludedPaths": [],
"compositeIndexes": [],
"spatialIndexes": [],
"vectorIndexes": [
{
"path": "/vector1",
"type": "flat"
},
{
"path": "/vector2",
"type": "quantizedFlat",
"quantizationByteSize": 3,
"vectorIndexShardKey": [
"/Country"
]
},
{
"path": "/vector3",
"type": "diskANN",
"quantizationByteSize": 2,
"indexingSearchListSize": 100,
"vectorIndexShardKey": [
"/ZipCode"
]
}
]
},
"vectorEmbeddingPolicy": {
"vectorEmbeddings": [
{
"path": "/vector1",
"dataType": "int8",
"dimensions": 1200,
"distanceFunction": "dotproduct"
},
{
"path": "/vector2",
"dataType": "uint8",
"dimensions": 3,
"distanceFunction": "cosine"
},
{
"path": "/vector3",
"dataType": "float32",
"dimensions": 400,
"distanceFunction": "euclidean"
}
]
},
"id": "test_binary_vector_container_6",
"partitionKey": {
"paths": [
"/pk"
],
"kind": "Hash"
}
}
```
## Type of change
Please delete options that are not relevant.
- [x] New feature (non-breaking change which adds functionality)
## Closing issues
To automatically close an issue: closes #4628
---------
Co-authored-by: Kiran Kumar Kolli <kirankk@microsoft.com>
Azure.Core: Fixed upgrading azure core dependency to 1.44.1 Changes - ResourceType: Conflict between Azure.Core and Microsoft.Azure.Cosmos.Documents - Microsoft.Bcl.AsyncInterfaces: Azure.Core needs at-least 6.0.0 (as Azure core upgraded part of minor version, we are good as well) - Microsoft.Azure.Cosmos.Encryption.Custom: Direct dependency on Azure.Core removed (now its transitive) - Microsoft.Azure.Cosmos.Encryption.Custom.Performance.Tests: `NU1903` added Newtonsoft.Json dependency - Performance project: `NU1903` Newtonsoft dependency upgraded
…onKeyStreamAsync API to GA (#4814) DeleteAllItemsByPartitionKeyStreamAsync: Adds DeleteAllItemsByPartitionKeyStreamAsync API to GA Changes - DeleteAllItemsByPartitionKeyStreamAsync: Marked virtual with default NotSupportedException (Dependent libraries will continue to work) - Encryption package related changes will be in a follow-up PR after the package is published
sourabh1007
force-pushed
the
users/sourabhjain/otelnetworkmetrics
branch
from
c382c69 to
f05a443
Compare
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/CosmosDbNetworkMeter.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryAttributeKeys.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Dec 13, 2024
kirankumarkolli
approved these changes
Dec 13, 2024
microsoft-github-policy-service
bot
deleted the
users/sourabhjain/otelnetworkmetrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
Network-Level Telemetry Implementation
DocumentClient.csfor client metrics.ClientContextCore.csto ensure consistent metric and trace collection.NetworkMetricDataandOperationMetricData.IActivityAttributePopulator.cs).CosmosDbNetworkMeter.cs.CosmosDbOperationMeter.csand aligned packages (TracesStabilityFactory.cs).ClientSideRequestStatisticsTraceDatum.cs.OpenTelemetryMetricsTest.cs.Reference: open-telemetry/semantic-conventions#1495
Type of change