[Internal] JSON Binary Encoding: Adds support for writing unsigned 64-bit integer values #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboshra
requested review from
khdang,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
|
Does this change contain any bugfixes (either by themselves or for previous commit)? Asking to see if it should be included in the release that's in progress. #Resolved |
- Added a new abstract method, `TryGetUInt64Value`, to both the `JsonReader` and `JsonNavigator` base classes. This method attempts to retrieve a number as an unsigned 64-bit integer. - Updated `JsonReader.WriteCurrentToken` and `JsonNavigator.WriteNode` to first attempt to retrieve the number as a UInt64 and write it as such if successful; otherwise, they fall back to writing it as a `Number64` value. - Corrected a typo in `JsonWriter.ForceRewriteRawJsonValue`, where the check for the Boolean value `enableNumberArrays` was mistakenly replaced by `enableEncodedStrings`. - Renamed `JsonNodeType.Number64` to `JsonNodeType.Number`. - Similarly, renamed `IJsonNavigator.GetNumber64Value` to `GetNumberValue`. - Enhanced JSON round-trip test validation to allow strict comparison, ensuring that the expected and actual buffers are identical.
|
It mainly adds support of reading/writing UInt64 values, which is soon to be needed once writing such values is enabled in the backend. In reply to: 2468664283 |
neildsh
approved these changes
Nov 13, 2024
khdang
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for serializing unsigned Int64 values in Binary encoding, ensuring that values exceeding the maximum signed Int64 limit are preserved without conversion to floating-point doubles. This enhancement enables full-fidelity roundtrips between Text and Binary encoding formats. For values outside the signed Int64 range, retrieval from either the JSON Reader or Navigator (across all encoding formats) will return them as floating-point doubles.
Type of change
Closing issues
None