Query correctly handles different language cultures #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os always stores JSON as InvariantCulture. This fixes a bug where if the user machine is set to French it will fail on parsing a double from Cosmos since Cosmos return InvariantCulture, but local parsing was using French culture.
bchong95
reviewed
Jul 17, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Json/JsonNavigatorTests.cs
Outdated
Show resolved
Hide resolved
bchong95
previously approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The query pipeline was using the local culture settings to parse the JSON. Cosmos stores the JSON as invariant culture. This would cause query parsing to fail and prevent the user from getting the results. The JSON navigator, reader, and writer are updated to always use invariant culture for parsing now.
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #542