Query correctly serializes the input into a stream #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
changed the title
Microsoft.Azure.Cosmos/src/Resource/Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
…lizer for each parameter property value to serialize it. All other properties are converted using the internal serializer. This allows users custom settings to still handle values, but not break any of the backend contracts.
j82w
changed the title
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemTests.cs
Outdated
Show resolved
Hide resolved
j82w
changed the title
added 2 commits
July 22, 2019 15:26
bchong95
reviewed
Jul 23, 2019
bchong95
reviewed
Jul 23, 2019
bchong95
reviewed
Jul 23, 2019
| writer.WritePropertyName("value"); | ||
|
|
||
| // Use the user serializer for the parameter values so custom conversions are correctly handled | ||
| using (Stream str = this.UserSerializer.ToStream(sqlParameter.Value)) |
There was a problem hiding this comment.
I think you can just use this methods:
https://www.newtonsoft.com/json/help/html/M_Newtonsoft_Json_JsonSerializer_Serialize.htm
There was a problem hiding this comment.
It needs to use the user's serializer for the parameter value. The current JSON serializer is our default implementation. This way we don't expose SqlQuerySpec, and don't require the user to have custom logic to handle the query object format for the backend.
bchong95
reviewed
Jul 23, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 23, 2019
kirankumarkolli
previously approved these changes
Jul 23, 2019
kirankumarkolli
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
SqlQuerySpec is internal and prevents users from serializing it breaking custom serializers. To fix this issue a custom serialization method was added to SqlQuerySpec. It will use the custom serializer for only the parameter property values. This allows date time handling and other custom serialization settings to be honored for the parameter values, and prevents those custom settings from breaking the expected format by the Cosmos service.
Type of change
Please delete options that are not relevant.
Closing issues
closes #575