Adding ToQueryDefinition method on an IQueryable #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
changed the title
j82w
reviewed
Jul 22, 2019
Microsoft.Azure.Cosmos/src/Resource/QueryResponses/QueryDefinition.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Jul 23, 2019
kirankumarkolli
requested changes
Jul 24, 2019
j82w
previously approved these changes
Jul 25, 2019
changelog.md
Outdated
| @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - [#557](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/557) Added trigger options to item request options | |||
| - [#571](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/571) Added a default JSON.net serializer with optional settings | |||
| - [#572](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/572) Added partition key validation on CreateContainerIfNotExistsAsync | |||
| - [#581](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/581) Adding ToQueryDefinition method on an IQueryable | |||
There was a problem hiding this comment.
How about user friendly message like
"LINQ to SqlQueryDefinition API"?
There was a problem hiding this comment.
We don't mention SQL anywhere else. "LINQ to QueryDefinition API"
There was a problem hiding this comment.
I am 50-50 on both name .On one side we are not using SQL in any iterator api. On other hand SqlQueryDefinition on LINQ would be more expressive ,as it explicitly tells that we will convert your LINQ to SQL
j82w
approved these changes
Jul 29, 2019
kirankumarkolli
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add ToQueryDefinition() method on IQueryable.
User can generate QueryDefinition() from LINQ and used it in stream api GetItemQueryStreamIterator.
Closing issues
closes #578