FeedResponse<T> status code now return OK for success instead of the invalid status code 0 or Accepted #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2019 07:29
changelog.md
Outdated
| @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - [#612](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/612) Bug fix for ReadFeed with partition-key | |||
| - [#614](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/614) Fixed SpatialPath serialization and compatibility with older index versions | |||
| - [#626](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/626) Fixed FeedResponse<T> status code | |||
There was a problem hiding this comment.
Please elaborate little more with what's the issue.
There was a problem hiding this comment.
Please see the updated title
kirankumarkolli
requested changes
Aug 3, 2019
j82w
changed the title
added 4 commits
August 6, 2019 05:11
…/Azure/azure-cosmos-dotnet-v3 into users/jawilley/query_status_code
kirankumarkolli
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The FeedResponse status code was not being set. This was caused by the child class not override the value. I removed the overrides to force the child classes to implement to the logic.
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #625