Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CreateContainerIfNotExistsAsync validation to limit to partitionKeyPath only #629

Merged
merged 5 commits into from
Aug 7, 2019

Conversation

simplynaveen20
Copy link
Member

Pull Request Template

Description

If user had created Container from SDK other than V3 with explicitly specifying
IsSystemKey = true or false and then trying to recreate with V3 api CreateContainerIfNotExistsAsync , sdk is throwing error which is should not.
This PR with address it

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

closes #623

@simplynaveen20 simplynaveen20 changed the title Fixing corner case for CreateContainerIfNotExistsAsync api Fixing issue for CreateContainerIfNotExistsAsync api Aug 2, 2019
j82w
j82w previously approved these changes Aug 2, 2019
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add entry into ChangeLog.md

@simplynaveen20
Copy link
Member Author

Please add entry into ChangeLog.md

This issue is not major scenario , and not reported by multiple users , also it was introduce in 3.1.0 and not in 3.0.0 so do we want to call it out ?

@j82w
Copy link
Contributor

j82w commented Aug 5, 2019

not reported by multiple users , also it was introduce in 3.1.0 and not in 3.0.0 so do we want to call it out ?

I believe we should still add it to the changelog. We had one customer already hit the issue. The point of the changelog is for customer to see the issues fixed so they know to upgrade without creating a new issue.

@simplynaveen20 simplynaveen20 changed the title Fixing issue for CreateContainerIfNotExistsAsync api Bug fix for CreateContainerIfNotExistsAsync api Aug 5, 2019
changelog.md Outdated Show resolved Hide resolved
@kirankumarkolli
Copy link
Member

not reported by multiple users , also it was introduce in 3.1.0 and not in 3.0.0 so do we want to call it out ?

I believe we should still add it to the changelog. We had one customer already hit the issue. The point of the changelog is for customer to see the issues fixed so they know to upgrade without creating a new issue.

Idea is share more context for developers to make deployment decision.
Less or ambiguous details will hurt new version adoptions.

@kirankumarkolli kirankumarkolli changed the title Bug fix for CreateContainerIfNotExistsAsync api Fixed CreateContainerIfNotExistsAsync validation to limited to partitionKeyPath only Aug 7, 2019
@kirankumarkolli kirankumarkolli changed the title Fixed CreateContainerIfNotExistsAsync validation to limited to partitionKeyPath only Fixed CreateContainerIfNotExistsAsync validation to limit to partitionKeyPath only Aug 7, 2019
@kirankumarkolli kirankumarkolli merged commit 64a0cad into master Aug 7, 2019
@kirankumarkolli kirankumarkolli deleted the users/nakumars/fixCreatIfExist branch August 7, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateContainerIfNotExistsAsync throws ArgumentException incorrectly stating the PKs don't match
3 participants