-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed CreateContainerIfNotExistsAsync validation to limit to partitionKeyPath only #629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add entry into ChangeLog.md
This issue is not major scenario , and not reported by multiple users , also it was introduce in 3.1.0 and not in 3.0.0 so do we want to call it out ? |
I believe we should still add it to the changelog. We had one customer already hit the issue. The point of the changelog is for customer to see the issues fixed so they know to upgrade without creating a new issue. |
Idea is share more context for developers to make deployment decision. |
Pull Request Template
Description
If user had created Container from SDK other than V3 with explicitly specifying
IsSystemKey = true or false and then trying to recreate with V3 api CreateContainerIfNotExistsAsync , sdk is throwing error which is should not.
This PR with address it
Please delete options that are not relevant.
Closing issues
closes #623