Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich user-agent with runtime context #630

Merged
merged 12 commits into from
Aug 8, 2019

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Aug 2, 2019

Description

This PR adds more information to the User Agent related to the runtime environment.

The current UserAgent contains this information:

{Platform}/{PlatformVersion} cosmos-netstandard-sdk/{Direct Version}

For example: Windows/10.0.18362 cosmos-netstandard-sdk/3.1.3

Now, we will have:

{Platform}/{PlatformVersion} cosmos-netstandard-sdk/{Direct Version} {SDK Version}-{Framework}{RuntimeArchitecture} {ClientId}

For example:

Windows/10.0.18362 cosmos-netstandard-sdk/3.1.3 3.1.0-.NET Core 4.6.27617.04 X64 <some-unique-identifier>

The {ClientId} is generated from DateTime.UtcNow.Ticks

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Closing issues

Closes #586

@ealsur ealsur added the feature-request New feature or request label Aug 2, 2019
@ealsur ealsur requested a review from kirankumarkolli August 2, 2019 23:46
@ealsur ealsur requested a review from kirillg as a code owner August 2, 2019 23:46
@ealsur ealsur self-assigned this Aug 2, 2019
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments

@kirankumarkolli
Copy link
Member

Add an entry in changelog.md

Copy link
Member

@simplynaveen20 simplynaveen20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve comment

simplynaveen20
simplynaveen20 previously approved these changes Aug 6, 2019
@ealsur
Copy link
Member Author

ealsur commented Aug 6, 2019

/azp Run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

changelog.md Outdated Show resolved Hide resolved
@kirankumarkolli kirankumarkolli merged commit 304e185 into master Aug 8, 2019
@kirankumarkolli kirankumarkolli deleted the users/ealsur/useragent branch August 8, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrich user-agent with runtime context
4 participants