-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling serialization customization through CosmosSerializerOptions #650
Merged
kirankumarkolli
merged 29 commits into
master
from
users/jawilley/serialization_options
Aug 10, 2019
Merged
Enabling serialization customization through CosmosSerializerOptions #650
kirankumarkolli
merged 29 commits into
master
from
users/jawilley/serialization_options
Aug 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…popular flags to make it easier for users that only require basic flags. Refactored all serializer classes into a single folder.
j82w
added
bug
Something isn't working
breaking
non-additive functional behavior changes
labels
Aug 7, 2019
Microsoft.Azure.Cosmos/src/Serializer/CosmosJsonDotNetSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/CosmosJsonDotNetSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/CosmosSerializerSettings.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
requested changes
Aug 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check comments
Microsoft.Azure.Cosmos/src/Serializer/CosmosJsonDotNetSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/CosmosSerializerSettings.cs
Outdated
Show resolved
Hide resolved
…ns to CosmosClientOptions. Added new UT.
j82w
changed the title
Converting CosmosJsonDotNetSerializer to use flags instead of JsonSerializerSettings to reduce dependency on Newtonsoft
Converting CosmosJsonDotNetSerializer to CosmosSerializerOptions to reduce dependency on Newtonsoft
Aug 7, 2019
kirankumarkolli
previously approved these changes
Aug 7, 2019
kirankumarkolli
changed the title
Converting CosmosJsonDotNetSerializer to CosmosSerializerOptions to reduce dependency on Newtonsoft
Enabling serialization customization through CosmosSerializerOptions
Aug 7, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/DotNetSDKAPI.json
Show resolved
Hide resolved
ausfeldt
previously approved these changes
Aug 8, 2019
bchong95
reviewed
Aug 9, 2019
kirankumarkolli
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The Azure core SDK teams has guidelines to remove the SDK dependency from Newtonsoft and instead use the System.Text.Json serialize that is now being included in dot net core. To reduce the friction of eventually moving to the new serializer exposing any additional types from Newtonsoft goes against Azure core SDK team.
Exposing the JsonSerializerSettings in CosmosJsonDotNetSerializer was missed in the review process, and is being considered a bug. For user convenience a new constructor is added that allows setting indentation, null handling, and camel casing.
Type of change
Please delete options that are not relevant.