Fix for an async deadlock, reported in #758 (and probably #717) #761
Conversation
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| @@ -45,7 +45,7 @@ public ICollection<TKey> Keys | |||
|
|
|||
| public void Set(TKey key, TValue value) | |||
| { | |||
| AsyncLazy<TValue> lazyValue = new AsyncLazy<TValue>(() => value, CancellationToken.None); | |||
| AsyncLazy<TValue> lazyValue = new AsyncLazy<TValue>(value); | |||
There was a problem hiding this comment.
Thoughts on how to UT/guard for future changes?
There was a problem hiding this comment.
Will TestCluster UT based approach validate it?
https://dotnet.github.io/orleans/Documentation/tutorials_and_samples/testing.html
There was a problem hiding this comment.
I think a test that uses AsyncCache with a single thread scheduler should suffice, without needing to use Orleans at all. I will try to create one.
There was a problem hiding this comment.
@kirankumarkolli I've added the test. Instead of adding a dependency on Orleans I've implemented a simple task scheduler in the Testing project that processes a single task at a time (SingleTaskScheduler). It can be reused in other tests to confirm the code doesn't deadlock.
I would suggest a code review, during which you could identify other places in the codebase where a task result is obtained in a blocking way (eg. .Result is called) - those will be potential deadlock spots.
|
Thanks alot @jkonecki for contribution. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Thanks alot @jkonecki |
|
Do you have any ETA for the next release of the NuGet package? |
Resolving an async deadlock caused by
AsyncCacheperforming a blocking wait.Type of change
Closing issues
Closes #758 and probably #717