Adding additional diagnostics context #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
reviewed
Sep 6, 2019
Microsoft.Azure.Cosmos/src/Resource/Settings/PointOperationStatistics.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Sep 6, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosContainerTests.cs
Show resolved
Hide resolved
…tistics.cs Co-Authored-By: Matias Quaranta <ealsur@users.noreply.github.com>
added 2 commits
September 6, 2019 15:36
kirankumarkolli
requested changes
Sep 9, 2019
kirankumarkolli
previously approved these changes
Sep 9, 2019
ealsur
previously approved these changes
Sep 10, 2019
kirankumarkolli
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Diagnostics is now populated for all responses. Additional information was added to the point operations. The additional information will help debugging and guarantees the to string will always have some data even if client side request statistics is null.
Type of change
Please delete options that are not relevant.