Incorrect key to throw CosmosExceptions with HttpStatusCode.Unauthorized status code #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillg
previously approved these changes
Sep 10, 2019
kirankumarkolli
approved these changes
Sep 10, 2019
|
ChaneLog missing |
kirankumarkolli
requested changes
Sep 10, 2019
kirankumarkolli
changed the title
j82w
reviewed
Sep 10, 2019
kirankumarkolli
approved these changes
Sep 10, 2019
j82w
approved these changes
Sep 10, 2019
|
This is not working on Microsoft.Azure.Cosmos 3.13.0. I still get a DocumentClientException |
|
@NRam0s can you create a new issue with more details on the scenario you are hitting this on? This PR added tests and the they are still passing so it shouldn't be throwing a DocumentClientException. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
If the CosmosClient is initialized with an invalid key, we are throwing a
DocumentClientExceptionthat is internal. This should be aCosmosException.Type of change
Closing issues
Closes #784