Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LINQ ThenBy operator after OrderBy #801

Merged
merged 11 commits into from
Oct 8, 2019

Conversation

khdang
Copy link
Member

@khdang khdang commented Sep 13, 2019

Description

  • Enable LINQ ThenBy operator after OrderBy to use composite indexing
  • Refactor LINQ tests

E.g

LINQ with ThenBy

query.OrderBy(f => f.FamilyId).ThenBy(f => f.Int).ThenByDescending(f => f.IsRegistered)

SQL

SELECT VALUE root 
FROM root 
ORDER BY root["FamilyId"] ASC, root["Int"] ASC, root["IsRegistered"] DESC

Type of change

  • New feature (non-breaking change which adds functionality)

Closing issues

@khdang khdang added the LINQ label Sep 13, 2019
@khdang khdang self-assigned this Sep 13, 2019
changelog.md Outdated Show resolved Hide resolved
@khdang khdang changed the title Enable LINQ ThenBy operator after OrderBy and add type check functions Enable LINQ ThenBy operator after OrderBy Sep 18, 2019
changelog.md Outdated Show resolved Hide resolved
@kirankumarkolli
Copy link
Member

@khdang can you please take a look at the test failures?

@khdang
Copy link
Member Author

khdang commented Oct 3, 2019

@khdang can you please take a look at the test failures?

I've updated the tests.

@khdang khdang closed this Oct 3, 2019
@khdang khdang reopened this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants