-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PartitionKeyDefinitionVersion to container builder. #844
Merged
kirankumarkolli
merged 8 commits into
master
from
users/jawilley/containerBuilder_partitionkey
Sep 27, 2019
Merged
Adding PartitionKeyDefinitionVersion to container builder. #844
kirankumarkolli
merged 8 commits into
master
from
users/jawilley/containerBuilder_partitionkey
Sep 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
reviewed
Sep 24, 2019
Microsoft.Azure.Cosmos/src/Fluent/Settings/ContainerDefinition.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Fluent/Settings/ContainerDefinition.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Sep 26, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/DotNetSDKAPI.json
Outdated
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Sep 27, 2019
kirankumarkolli
deleted the
users/jawilley/containerBuilder_partitionkey
branch
September 27, 2019 21:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adding partition key definition version to the container builder.
Type of change
Please delete options that are not relevant.
Related comment: #833 (comment)