Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk retry on namestale #859

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Bulk retry on namestale #859

merged 1 commit into from
Sep 27, 2019

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Sep 27, 2019

Pull Request Template

Description

Bulk flow should retry on NameStale Cache, this PR modifies the retry policy to cover that case and adds a UT to verify it.

@ealsur ealsur added the bug Something isn't working label Sep 27, 2019
@ealsur ealsur self-assigned this Sep 27, 2019
@ealsur ealsur mentioned this pull request Sep 27, 2019
Merged
kirankumarkolli
kirankumarkolli requested changes Sep 27, 2019
View reviewed changes
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source changes are not required. Generic Gone retry is super set and covers NameCacheStale

@kirankumarkolli kirankumarkolli merged commit 95edbdf into master Sep 27, 2019
@kirankumarkolli kirankumarkolli deleted the users/ealsur/bulkstale branch September 27, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

@ealsur ealsur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ealsur @kirankumarkolli