Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed user agent string #860

Merged
merged 5 commits into from
Oct 7, 2019
Merged

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Sep 30, 2019

Pull Request Template

Description

Fixed a bug that caused the user agent overrides to not get applied. Refactored the Doucments.UserAgentContainer to allow the base user agent string to be overriden.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@j82w j82w added the bug Something isn't working label Sep 30, 2019
@j82w j82w self-assigned this Sep 30, 2019
ealsur
ealsur previously approved these changes Sep 30, 2019
kirankumarkolli
kirankumarkolli previously approved these changes Oct 1, 2019
@j82w j82w dismissed stale reviews from kirankumarkolli and ealsur via 77ca09f October 4, 2019 00:01
@kirankumarkolli kirankumarkolli merged commit a3db597 into master Oct 7, 2019
@kirankumarkolli kirankumarkolli deleted the users/jawilley/user_agent_hotfix branch October 7, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants