Fixed invalid user agent format exception for Mac OS. #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausfeldt
previously approved these changes
Oct 10, 2019
|
There are reports based on separator which might need refreshing. Can you please run it through Deborah once? |
ealsur
reviewed
Oct 10, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/HeadersValidationTests.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Oct 11, 2019
…each client instance.
added 2 commits
October 11, 2019 08:16
ealsur
reviewed
Oct 11, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/UserAgentTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Oct 11, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/EnvironmentInformationTests.cs
Show resolved
Hide resolved
added 3 commits
October 11, 2019 09:43
ealsur
previously approved these changes
Oct 11, 2019
kirankumarkolli
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The http headers only allow certain formats. The Mac OS creates a operating system string that causes the validation to fail. The / are converted | so it does not hit the same issue.
Examples:
cosmos-netstandard-sdk/3.3.0|3.3.0|60526|X64|Darwin 18.0.0 Darwin Kernel V|.NET Core 4.6.28008.01| UserApplicationName/1.0cosmos-netstandard-sdk/3.3.0|3.3.0|28400|X64|Microsoft Windows 10.0.18362 |.NET Core 4.6.28008.01| UserApplicationName/1.0Type of change
Please delete options that are not relevant.
Closing issues
Put fixes #891