Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializer for service types iterators #918

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Oct 16, 2019

Pull Request Template

Description

Sprocs, Triggers, UDFs, Permissions, and Conflict iterators were using the user-provided serializer instead of the internal one to ensure a correct deserialization.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@ealsur ealsur added the bug Something isn't working label Oct 16, 2019
@ealsur ealsur requested a review from j82w October 16, 2019 19:42
@ealsur ealsur self-assigned this Oct 16, 2019
j82w
j82w previously approved these changes Oct 16, 2019
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting of conflicts part

@kirankumarkolli kirankumarkolli merged commit 428394f into master Oct 22, 2019
@kirankumarkolli kirankumarkolli deleted the users/ealsur/serializerforinternal branch October 22, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants