Adding User Agent suffix when Bulk mode is on #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In order to have visibility on requests having Bulk mode on, this PR adds a suffix when the feature is on.
The suffix adds a bit array for features to the base UserAgentContainer like so:
cosmos-netstandard-sdk/3.3.2|3.4.0|55405|X64|Microsoft Windows 10.0.18362 |.NET Core 4.6.28008.01**|F 00000001**| UserApplicationName/1.0
If Bulk support is off, there is nothing added to the base string.
Additionally, the
CosmosClientOptionswill not create the UserAgentContainer when GetConnectionPolicy is called, not before, as it is not needed, until the ConnectionPolicy is requested.Also, fixes the casing in
WithBulkexecutionto beWithBulkExecutionfor the builder extension.Type of change
Please delete options that are not relevant.