fix error with partial count returned #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchong95
previously approved these changes
Oct 22, 2019
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
reviewed
Oct 22, 2019
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Oct 22, 2019
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs
Show resolved
Hide resolved
j82w
reviewed
Oct 22, 2019
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Oct 22, 2019
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
j82w
previously approved these changes
Oct 22, 2019
...osoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosOrderByItemQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Oct 22, 2019
...osoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosOrderByItemQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
bchong95
approved these changes
Oct 22, 2019
j82w
pushed a commit
that referenced
this pull request
Oct 29, 2019
* fix error with partial count returned * Added tests, fixed order by drain bug, and updated changelog * Updated the failure handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This prevents an issue where a partial aggregate can be returned instead of error 429 in some cases.
Type of change
Please delete options that are not relevant.
Closing issues
Assignee
Projects