Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve Order of Projections in GROUP BY Query #934

Merged
merged 12 commits into from
Oct 31, 2019
Merged

Preserve Order of Projections in GROUP BY Query #934

merged 12 commits into from
Oct 31, 2019

Conversation

bchong95
Copy link
Contributor

Preserve Order of Projections in GROUP BY Query

Description

Preserve Order of Projections in GROUP BY Query.

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@sboshra
Copy link
Contributor

sboshra commented Oct 29, 2019 

    private sealed class EagerCosmosObject : CosmosObject

please merge w/ the OrderedCosmosObject class

Refers to: Microsoft.Azure.Cosmos/src/CosmosElements/CosmosObject.EagerCosmosObject.cs:20 in 41c836b. [](commit_id = 41c836b, deletion_comment = False)

sboshra
sboshra previously approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bchong95 bchong95 requested a review from kirillg as a code owner October 30, 2019 16:56
@bchong95 bchong95 self-assigned this Oct 30, 2019
j82w
j82w previously approved these changes Oct 31, 2019
View reviewed changes
sboshra
sboshra approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sboshra sboshra merged commit f0e0fdf into master Oct 31, 2019
@sboshra sboshra deleted the users/brchon/Query/PerserveOrderingOfGroupByProjections branch October 31, 2019 21:28
ealsur pushed a commit that referenced this pull request Nov 19, 2019
@bchong95 @ealsur
Preserve Order of Projections in GROUP BY Query (#934)
e0f8e58 
* added ordred cosmos object

* wired through group by change

* removing unneeded tests

* resolved iteration comments

* resolved iteration comments

* fixed key not found exceptions

* updated changelog

* dummy commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboshra sboshra sboshra approved these changes

@j82w j82w j82w left review comments

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

@bchong95 bchong95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bchong95 @sboshra @j82w