Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORDER BY Undefined #952

Merged
merged 4 commits into from
Oct 31, 2019
Merged

ORDER BY Undefined #952

merged 4 commits into from
Oct 31, 2019

Conversation

bchong95
Copy link
Contributor

@bchong95 bchong95 commented Oct 31, 2019 •
edited by mbhaskar
Loading

ORDER BY Undefined

Description

Allows for ordering by undefined fields. The fix was just to allow nulls to propagate through the sort code.

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@bchong95 bchong95 self-assigned this Oct 31, 2019
@bchong95 bchong95 mentioned this pull request Oct 31, 2019
Closed
sboshra
sboshra approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sboshra sboshra merged commit 9dec2c8 into master Oct 31, 2019
@sboshra sboshra deleted the users/brchon/Query/OrderByUndefined branch October 31, 2019 17:20
ealsur pushed a commit that referenced this pull request Nov 19, 2019
@bchong95 @ealsur
ORDER BY Undefined (#952)
29750ee 
* reproduced issue

* got tests to pass

* removed mixed type order by check

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboshra sboshra sboshra approved these changes

@j82w j82w j82w approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@jasontho-ms jasontho-ms Awaiting requested review from jasontho-ms

Assignees

@bchong95 bchong95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bchong95 @kirankumarkolli @j82w @sboshra