Fix mocking for FeedIterator and Response classes #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchong95
previously approved these changes
Nov 6, 2019
j82w
changed the title
added 2 commits
November 6, 2019 09:34
ealsur
approved these changes
Nov 6, 2019
ausfeldt
approved these changes
Nov 6, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosVirtualUnitTest.cs
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Nov 6, 2019
j82w
added a commit
that referenced
this pull request
Nov 6, 2019
* Fix feed iterator for mocking * Updated changelog * Added method back * Fixed type casting * Removed additional internal abstract types. Added UT * Removed unused variable * Updated changelog * Fixed tests
dpgregory
pushed a commit
to dpgregory/azure-cosmos-dotnet-v3
that referenced
this pull request
Nov 7, 2019
* Fix feed iterator for mocking * Updated changelog * Added method back * Fixed type casting * Removed additional internal abstract types. Added UT * Removed unused variable * Updated changelog * Fixed tests
|
Can you explain how we can use the FeedIterator in a Mock? |
|
@kellyprankin can you create an issue asking for samples on how to mock query with feed iterator? |
ealsur
pushed a commit
that referenced
this pull request
Nov 19, 2019
* Fix feed iterator for mocking * Updated changelog * Added method back * Fixed type casting * Removed additional internal abstract types. Added UT * Removed unused variable * Updated changelog * Fixed tests
j82w
pushed a commit
that referenced
this pull request
Nov 22, 2019
* Make SessionToken on QueryRequestOptions public * Fix mocking for FeedIterator and Response classes (#978) * Fix feed iterator for mocking * Updated changelog * Added method back * Fixed type casting * Removed additional internal abstract types. Added UT * Removed unused variable * Updated changelog * Fixed tests * Updating package (#975) * Update azure-pipelines-official.yml (#970) * Update changelog with 979 * Move line in changelog to correct location * Remove added in change log to correct location
j82w
pushed a commit
that referenced
this pull request
Nov 22, 2019
* Make SessionToken on QueryRequestOptions public * Fix mocking for FeedIterator and Response classes (#978) * Fix feed iterator for mocking * Updated changelog * Added method back * Fixed type casting * Removed additional internal abstract types. Added UT * Removed unused variable * Updated changelog * Fixed tests * Updating package (#975) * Update azure-pipelines-official.yml (#970) * Update changelog with 979 * Move line in changelog to correct location * Remove added in change log to correct location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Users can't mock an internal abstract method. Removing the internal abstract method to fix unit testing.
Fixes #977