Change a few expecting exceptions (#351)

Azure · Nov 19, 2018 · c5a9f05 · c5a9f05
1 parent 27aa79c
commit c5a9f05
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Microsoft.Azure.EventHubs/Primitives/Guard.cs b/src/Microsoft.Azure.EventHubs/Primitives/Guard.cs
@@ -9,15 +9,15 @@ internal static void ArgumentNotNull(string argumentName, object value)
         {
             if (value == null)
             {
-                Fx.Exception.ArgumentNull(argumentName);
+                throw Fx.Exception.ArgumentNull(argumentName);
             }
         }
 
         internal static void ArgumentNotNullOrWhiteSpace(string argumentName, string value)
         {
             if (string.IsNullOrWhiteSpace(value))
             {
-                Fx.Exception.ArgumentNull(argumentName);
+                throw Fx.Exception.ArgumentNull(argumentName);
             }
         }
     }

diff --git a/test/Microsoft.Azure.EventHubs.Tests/Client/NegativeCases.cs b/test/Microsoft.Azure.EventHubs.Tests/Client/NegativeCases.cs
@@ -130,7 +130,7 @@ await Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () =>
             invalidPartitions = new List<string>() { "", " ", null };
             foreach (var invalidPartitionId in invalidPartitions)
             {
-                await Assert.ThrowsAsync<ArgumentException>(async () =>
+                await Assert.ThrowsAsync<ArgumentNullException>(async () =>
                 {
                     TestUtility.Log($"Sending to invalid partition {invalidPartitionId}");
                     sender = this.EventHubClient.CreatePartitionSender(invalidPartitionId);
@@ -162,7 +162,7 @@ await Assert.ThrowsAsync<InvalidOperationException>(async () =>
             invalidPartitions = new List<string>() { "", " ", null };
             foreach (var invalidPartitionId in invalidPartitions)
             {
-                await Assert.ThrowsAsync<ArgumentException>(async () =>
+                await Assert.ThrowsAsync<ArgumentNullException>(async () =>
                 {
                     TestUtility.Log($"Getting partition information from invalid partition {invalidPartitionId}");
                     await this.EventHubClient.GetPartitionRuntimeInformationAsync(invalidPartitionId);
@@ -179,7 +179,7 @@ Task CreateClientWithoutEntityPathShouldFail()
             var csb = new EventHubsConnectionStringBuilder(TestUtility.EventHubsConnectionString);
             csb.EntityPath = null;
 
-            return Assert.ThrowsAsync<ArgumentException>(() =>
+            return Assert.ThrowsAsync<ArgumentNullException>(() =>
             {
                 EventHubClient.CreateFromConnectionString(csb.ToString());
                 throw new Exception("Entity path wasn't provided in the connection string and this new call was supposed to fail");