Vendor the azblob 0.6.0 dependency so customers can upgrade to later blobs packages #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendrixMSFT
force-pushed
the
ehold-vendor-storage
branch
4 times, most recently
from
096ee84 to
fb63fff
Compare
richardpark-msft
changed the title
|
/azp run Azure.azure-event-hubs-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jhendrixMSFT
force-pushed
the
ehold-vendor-storage
branch
from
fb63fff to
0b70bda
Compare
|
/azp run Azure.azure-event-hubs-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jhendrixMSFT
approved these changes
Jul 26, 2022
|
/azp run Azure.azure-event-hubs-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…eTypes are strings they don't "match" when it comes to determining if they're the same type. Aliasing should work just fine here.
|
When will this be merged in? I have an issue using an updated snowflakedb (1.6.13) which needs azure-blobs 0.14.0 but azure-events-hub still requires azure-blobs 0.6.0, any recommended work arounds for such issues which leads the issues mentioned in |
|
@aarshshah-8 sorry for the delay, this has been tagged and released |
No worries! Thank you for taking care of it so quick. Tested it out and it works great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azblob@v0.6.0 is a beta dependency we use for storage checkpointing. More recent releases won't compile with our package, which means that customers that want to move forward can't.
Vendoring this dependency allows us to avoid doing that upgrade until the blob package has finalized, or until we migrate over to the latest package released in azure-sdk-for-go.
Fixes #261