Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to Keda version 1.2.0 #1811

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Updating to Keda version 1.2.0 #1811

merged 3 commits into from
Feb 12, 2020

Conversation

SatishRanjan
Copy link
Contributor

No description provided.

@ahmelsayed
Copy link
Contributor

I think you need to update the entire yaml file by one generated from the keda repo or the chart repo because there has been changes to the yaml structure in this release. See kedacore/keda#506

ahmelsayed
ahmelsayed requested changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core-tools always uses the name keda instead of keda-operator. so let's keep it that way so the update can work, i.e replace all keda-operator with keda. But otherwise looks good

@SatishRanjan SatishRanjan merged commit 88001c9 into Azure:dev Feb 12, 2020
@SatishRanjan SatishRanjan deleted the keda-1.2.0 branch February 12, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@anirudhgarg anirudhgarg Awaiting requested review from anirudhgarg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SatishRanjan @ahmelsayed