Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve publishing speed for Typescript apps #3145

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Improve publishing speed for Typescript apps #3145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
444b441
Don't publish developer tooling for typescript apps
wwestrop Sep 7, 2022
476ced8
Reinstate some paths under npm_modules
wwestrop Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Azure.Functions.Cli/StaticResources/funcignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@
local.settings.json
test
getting_started.md
node_modules/@types/
node_modules/azure-functions-core-tools/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the most impactful line, and I think it makes total sense to add it. Thank you!!!

Fwiw, adding to the funcignore will help with one-off deployments from core tools. However, if you deploy through a CI/CD pipeline I would recommend adding npm prune --production before deploying, which will more consistently get rid of all dev dependencies.

Another fwiw, VS Code will run npm prune --production by default if you deploy through there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm prune is a good shout, I was just trying to do a quick-n-dirty functionapp in this case 😉

node_modules/typescript/