-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary support for linux-arm64 #3584
base: v4.x
Are you sure you want to change the base?
Conversation
@vrdmr @Francisco-Gamino @andystaples @amamounelsayed @ejizba @hossam-nasr @AnatoliB @khkh-ms This PR was opened 2 months ago. Can somebody review it? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@khkh-ms Thanks for the review! FYI it appears the test failure is just a missing config in the test environment, and it's not clear to me why that'd be related to the current change. |
/azp run |
Commenter does not have sufficient privileges for PR 3584 in repo Azure/azure-functions-core-tools |
The test is failing with the single following error: |
I've determined that "AZURE_MANAGEMENT_ACCESS_TOKEN" is referred to in only two places:
|
The error is being thrown from this piece of code:
at Azure.Functions.Cli.Tests.E2E.AzureResourceManagers.BaseAzureResourceManager.get_AccessToken() Which seems to indicate that, exactly as expected and mentioned above, an environment variable is not being set for this test environment, and that that is the reason this entire PR is being held back, and not an issue with the code in the PR itself. So what can we do next to push this forward? At the moment the community can not actually run Azure Functions in a dev container on a M1,M2 Mac. This is such a blocker. Should we be looking to try and build the solution locally, and patch it ourselves? |
I did manage to have some level of success with the fix. The next problem that I am facing is that there is no worker for workers/python/3.11/LINUX/Arm64. Thank you! |
@dirkesquire where is it missing from exactly? I've been trying to trace this through and it seems like the Arm64 version should exist: https://github.com/Azure/azure-functions-python-worker/blob/cd13c6aa1db0aba958f4aedded80254d69040899/python/prodV4/worker.config.json#L7 |
Add support for Debian11 (bulleye) on ARM64.
Issue describing the changes in this PR
resolves #3112
Pull request checklist