Custom host changes for VS Scenario #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
reviewed
Sep 24, 2024
kshyju
reviewed
Sep 24, 2024
kshyju
reviewed
Sep 24, 2024
kshyju
reviewed
Sep 24, 2024
kshyju
reviewed
Sep 24, 2024
kshyju
reviewed
Sep 24, 2024
kshyju
reviewed
Sep 24, 2024
kshyju
approved these changes
Sep 24, 2024
drdamour
reviewed
Oct 7, 2024
| } | ||
| if (!string.IsNullOrEmpty(fileContent)) | ||
| { | ||
| var localSettingsJObject = JsonDocument.Parse(fileContent); |
There was a problem hiding this comment.
this line gave me a bad weekend :( glad #3866 is addressing some of it (but still not allowing my sweet sweet trailing commas :D )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #3814
This PR creates the custom host needed for VS for the core tools scenario. Today we look at the user's
local.settings.jsonto read the values if the function app is dotnet and if the user is running a .NET 8 in-proc app. We then load the appropriatefunc.dlldepending on if we want to load an inproc6 or inproc8. The out-of-process scenario will be addressed in a separate PR.Pull request checklist