Add command to create Durable Task helpers #947
Conversation
|
@cgillum - would love your thoughts on this :-) |
There was a problem hiding this comment.
Just a couple of minor comments from me. @cgillum, @glennamanns or @kashimiz would know better than me regarding the function aspects of the change.
src/Azure.Functions.Cli/Actions/DurableActions/DurableCreateHelpersAction.cs
Show resolved
Hide resolved
| @@ -0,0 +1,264 @@ | |||
| ## Ignore Visual Studio temporary files, build results, and | |||
There was a problem hiding this comment.
Do you need a .gitignore per scenario here? seems a bit too much :)
There was a problem hiding this comment.
Agreed! I'll look at moving that up a level to avoid one per scenario
There was a problem hiding this comment.
This is done in the latest commits
| if (workerRuntime != WorkerRuntime.dotnet) | ||
| { | ||
| ColoredConsole.WriteLine(ErrorColor($"create-durable-helpers does not support runtime: {workerRuntime}")); | ||
| return; |
There was a problem hiding this comment.
throw here so that the exit code is set correctly, or set the exit code yourself.
There was a problem hiding this comment.
Updated this to set the exit code
|
@ahmelsayed - I believe the changes you requested are made in the latest commits. Let me know if you have any further comments @cgillum, @glennamanns, @kashimiz - would love your thoughts :-) |
stuartleeks
force-pushed
the
durable-task-helpers
branch
2 times, most recently
from
9ed4cc3
to
8282b14
Compare
|
I have now added the SubOrchestrator helper generation. |
| <PackageReference Include="Buildalyzer.Workspaces" Version="2.0.0" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis" Version="2.9.0" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="2.9.0" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="2.9.0" /> |
There was a problem hiding this comment.
@ahmelsayed Just to confirm, you're good with these new CLI dependencies?
There was a problem hiding this comment.
I added Buildalyzer as Roslyn doesn't currently have support for MSBuildWorkspace (the type that let's you create a workspace from a csproj file) in .NET Core: dotnet/roslyn#17974
Buildalyzer source is here under an MIT license.
There was a problem hiding this comment.
sorry for the delay, just saw these comments. I think the runtime already brings in the CodeAnalysis packages. I don't really have any particular concerns unless @fabiocav does.
|
A quick note from a conversation with @cgillum: This PR only works for |
stuartleeks
force-pushed
the
durable-task-helpers
branch
from
8282b14
to
fa1e915
Compare
|
Just rebased on |
|
Is there any more feedback on this? :-) |
|
I'm closing this old PR. If this is something that we still need to look at, please work with @fabiocav to get this rebased and merged. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Initial implementation for #946 for review/comment.
Currently handles generating helpers for activities and sub-orchestrations - considering whether to add
StartNewhelpers.The PR adds a single new command
func durable create-helpers. This command doesn't require any arguments as it picks up all the information from the function project.As with other commands in the CLI, this expects to be run from the function project folder.