Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release for 1.8.4 #1054

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Prepare release for 1.8.4 #1054

merged 3 commits into from
Dec 5, 2019

Conversation

ConnorMcMahon
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon commented Nov 16, 2019

  • Update to version 1.8.4
  • Use DurableTask.AzureStorage to 1.6.5
  • Update samples to use new version.

@ConnorMcMahon
Copy link
Contributor Author

There are 3 open issues on the milestone that aren't fix-ready or documentation tagged.

#771 - I'm hesitant to move forward on this issue until a non-prerelease of Microsoft.NET.Sdk.Functions that unblock 2.3.0 usage moves forward.

#951 - Not sure how much work needs to be done on the extension side to light this up. Will investigate.

#934 - Not sure if this is something we can address until we support BYO serialization, which is likely a 2.0 only feature. The customer has a workaround, so I don't necessarily want to hold on the release for this.

Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. What's the plan for #771? Is this something Fabio's team is working on? Also, I'm fine punting #934 if it's not straightforward.

@ConnorMcMahon
Copy link
Contributor Author

I pinged Fabio in one of the core open issues in the corresponding repo, so I will know soon regarding that issue.

@@ -45,7 +45,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Azure.DurableTask.AzureStorage" Version="1.6.3" />
<PackageReference Include="Microsoft.Azure.DurableTask.AzureStorage" Version="1.6.4" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to update to the newest version, 1.6.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@amdeel
Copy link
Contributor

amdeel commented Nov 19, 2019

The #934 fix would probably include custom serialization settings in DurableTask.Core, the changes that I am currently working on. I can prioritize this work if it would help.

@ConnorMcMahon ConnorMcMahon merged commit 54767c5 into v1 Dec 5, 2019
@ConnorMcMahon ConnorMcMahon deleted the PrepareRelease branch April 9, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants